GitHub user srdo opened a pull request:

    https://github.com/apache/storm/pull/2156

    STORM-2549: Fix broken enforcement mechanism for maxUncommittedOffset…

    …s in storm-kafka-client spout
    
    Please see https://issues.apache.org/jira/browse/STORM-2549 and maybe also 
the comments on https://issues.apache.org/jira/browse/STORM-2343
    
    This moves enforcement of maxUncommittedOffsets to the partition level. I 
don't believe there's a way to enforce the single limit globally without 
hitting a bunch of issues with it either being too strict regarding retries, or 
not being strict enough and allowing an unbounded number of new tuples along 
with the retries.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/srdo/storm STORM-2549

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2156.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2156
    
----
commit 3837a6be6d9533e27058c32ed427bac7e4c684f4
Author: Stig Rohde Døssing <[email protected]>
Date:   2017-06-10T17:38:22Z

    STORM-2549: Fix broken enforcement mechanism for maxUncommittedOffsets in 
storm-kafka-client spout

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to