Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2164#discussion_r122565494
  
    --- Diff: storm-client/src/jvm/org/apache/storm/utils/DisruptorQueue.java 
---
    @@ -502,15 +502,26 @@ private static Long getId() {
     
         private void publishDirectSingle(Object obj, boolean block) throws 
InsufficientCapacityException {
             long at;
    +        long numberOfTuples;
             if (block) {
                 at = _buffer.next();
             } else {
                 at = _buffer.tryNext();
             }
             AtomicReference<Object> m = _buffer.get(at);
             m.set(obj);
    +        if (obj instanceof ArrayList) {
    --- End diff --
    
    Seems like the logic for counting number of tuples is duplicated so better 
to extract method.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to