Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2163#discussion_r122565809
--- Diff:
external/storm-redis/src/main/java/org/apache/storm/redis/common/config/JedisClusterConfig.java
---
@@ -44,14 +45,16 @@
* @param nodes list of node information for JedisCluster
* @param timeout socket / connection timeout
* @param maxRedirections limit of redirections - how much we'll
follow MOVED or ASK
+ * @param password password, if any
* @throws NullPointerException when you didn't set nodes
*/
- public JedisClusterConfig(Set<InetSocketAddress> nodes, int timeout,
int maxRedirections) {
+ public JedisClusterConfig(Set<InetSocketAddress> nodes, int timeout,
int maxRedirections, String password) {
--- End diff --
Though we also have builder class as well, it would be better to have a
separate constructor which doesn't have password as parameter, given that it
was `public`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
