Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2159#discussion_r122571301
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutMessageId.java
---
@@ -21,7 +21,9 @@
import org.apache.kafka.clients.consumer.ConsumerRecord;
import org.apache.kafka.common.TopicPartition;
-public class KafkaSpoutMessageId {
+import java.io.Serializable;
+
+public class KafkaSpoutMessageId implements Serializable{
private final transient TopicPartition topicPart;
--- End diff --
I think they probably shouldn't be. The eventlogger will be more useful if
it can log topicpartition and offset.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
