Github user arunmahadevan commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2171#discussion_r123424946
  
    --- Diff: 
external/storm-autocreds/src/main/java/org/apache/storm/hbase/security/HBaseSecurityUtil.java
 ---
    @@ -67,7 +67,7 @@ public static UserProvider login(Map conf, Configuration 
hbaseConfig) throws IOE
                 }
                 return legacyProvider;
             } else {
    -            return UserProvider.instantiate(hbaseConfig);
    +            return null;
    --- End diff --
    
    Wont this throw NPE in the caller ?
    
    check: 
https://github.com/apache/storm/blob/1.x-branch/external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/state/HBaseMapState.java#L84



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to