Github user revans2 commented on the issue:

    https://github.com/apache/storm/pull/2083
  
    @mal that is not an issue right now.  There are a lot of changes to the 
code, but most of that is creating some common helper methods and refactoring.  
The only configs really impacted by this change are the daemon childopts 
`{nimbus,drpc,pacemaker,logviewer,ui}.childopts`  these were all really just 
read by storm.py by way of the ConfigValue command.  Which would then parse 
them using 
    
    https://github.com/apache/storm/blob/master/bin/storm.py#L217-L234
    
    the old code just output the value by calling .toString on it, but the new 
ConfigValue will first check if it is a list and stitch it back together into a 
String. So
    
    ```
    "-foo \"hello world\"" => "-foo \"hello world\"" => ["-foo", "hello world"]
    "-padding \"     \""   => "-padding \"     \""  => ["-padding", "     "]
    ```
    but
    
    ```
    ["-foo", "hello world"] => "-foo hello world" => ["-foo", "hello", "world"]
    ["-padding", "    "] => "-padding     " => ["-padding"]
     ```
    
    This is not ideal, I agree.  Ultimately we need to add in an option to 
storm config to print out the config as a JSON string, or a set of JSON 
strings.  Then have storm.py parse it properly and add in the arguments the 
right way to respect white space instead of what is happening right now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to