Github user harshach commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2157#discussion_r124087558
  
    --- Diff: 
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/bolt/AbstractHdfsBolt.java
 ---
    @@ -297,9 +296,21 @@ protected Path getBasePathForNextFile(Tuple tuple) {
     
         abstract protected String getWriterKey(Tuple tuple);
     
    -    abstract protected AbstractHDFSWriter makeNewWriter(Path path, Tuple 
tuple) throws IOException;
    +    abstract protected Writer makeNewWriter(Path path, Tuple tuple) throws 
IOException;
     
    -    static class WritersMap extends LinkedHashMap<String, 
AbstractHDFSWriter> {
    +    public interface Writer {
    --- End diff --
    
    can you move this into this its own file rather than putting it in HDFSBolt


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to