Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1950#discussion_r124484454
--- Diff:
external/storm-redis/src/main/java/org/apache/storm/redis/state/RedisKeyValueState.java
---
@@ -316,10 +340,18 @@ private Long lastPreparedTxid() {
private Long lastId(String key) {
Long lastId = null;
- String str = txIds.get(key);
- if (str != null) {
- lastId = Long.valueOf(str);
+ String txId = txIds.get(key);
+ if (txId != null) {
+ lastId = Long.valueOf(txId);
}
return lastId;
}
+
+ private ConcurrentNavigableMap<byte[], byte[]>
createPendingPrepareMap() {
+ return new
ConcurrentSkipListMap<>(UnsignedBytes.lexicographicalComparator());
+ }
+
+ private NavigableMap<byte[], byte[]> createPendingCommitMap() {
--- End diff --
Seems this is not used. If so can be removed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
