Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2180#discussion_r124883491
--- Diff: storm-client/src/jvm/org/apache/storm/StormSubmitter.java ---
@@ -78,21 +78,18 @@ public static boolean validateZKDigestPayload(String
payload) {
@SuppressWarnings("unchecked")
public static Map prepareZookeeperAuthentication(Map<String, Object>
conf) {
Map toRet = new HashMap();
-
+ String secretPayload = (String)
conf.get(Config.STORM_ZOOKEEPER_TOPOLOGY_AUTH_PAYLOAD);
// Is the topology ZooKeeper authentication configuration unset?
if (!
conf.containsKey(Config.STORM_ZOOKEEPER_TOPOLOGY_AUTH_PAYLOAD) ||
conf.get(Config.STORM_ZOOKEEPER_TOPOLOGY_AUTH_PAYLOAD) ==
null ||
! validateZKDigestPayload((String)
conf.get(Config.STORM_ZOOKEEPER_TOPOLOGY_AUTH_PAYLOAD))) {
-
- String secretPayload = generateZookeeperDigestSecretPayload();
+ secretPayload = generateZookeeperDigestSecretPayload();
+ }
toRet.put(Config.STORM_ZOOKEEPER_TOPOLOGY_AUTH_PAYLOAD,
secretPayload);
LOG.info("Generated ZooKeeper secret payload for MD5-digest: "
+ secretPayload);
--- End diff --
Please move this line up to be right below line 87. We don't want to log
that we generated a payload unless we actually did.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
