Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2181#discussion_r124906648
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/OffsetManager.java
---
@@ -162,7 +164,7 @@ public long commit(OffsetAndMetadata committedOffset) {
LOG.debug("Committed offsets [{}-{} = {}] for topic-partition
[{}].",
preCommitCommittedOffsets + 1, this.committedOffset,
numCommittedOffsets, tp);
- return numCommittedOffsets;
+ return numCommittedOffsets - 1;// The committed offset should be
the next message
--- End diff --
Please fix this in L144 instead, so the log messages above print the right
number as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
