Github user srdo commented on the issue:

    https://github.com/apache/storm/pull/2206
  
    The build error is unrelated to this change, I think the cherry pick of 
https://github.com/apache/storm/pull/2195/files to 1.1.x-branch broke it. 
@HeartSaVioR if you get the chance could you take a look at it?
    
    I'm of the opinion that it's too hard to enforce a maxUncommittedOffset 
globally for all partitions (we keep hitting edge cases where either the limit 
is ignored, or the spout is prevented from progressing), so I'd like to see us 
move to a per-partition limit (PR here 
https://github.com/apache/storm/pull/2156). That PR proposes moving 
numUncommittedOffsets into the OffsetManager, which means it automatically gets 
nulled when a partition is reassigned.
    
    Basically I'd like to see if we can get 
https://github.com/apache/storm/pull/2156 discussed first. If we decide not to 
merge that one, then I think this is probably a good change, and I'd be happy 
to test this out then.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to