Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2241
@harshach
As I commented multiple times, this patch is mixed up of replacing queue,
changing message subsystem, and micro-optimization. Three committers already
had a look at the first pass (excluding @revans2 since he stopped reviewing)
but we couldn't identify any critical problems unless @revans2 shared the test
result. If we go on with this patch, we even don't know which part of change
contribute s performance gain and how much it is.
If we were having PR only replacing JCTools, it is easy to review and
identify the benefit, or pros/cons of replacing Disruptor with JCTools. The
patch will be fairly simple to review and verify, and most of the issues raised
here shouldn't be raised there (because I guess most of them are not from queue
replacement).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
