Github user roshannaik commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2241#discussion_r129931296
  
    --- Diff: conf/defaults.yaml ---
    @@ -231,16 +228,13 @@ topology.multilang.serializer: 
"org.apache.storm.multilang.JsonSerializer"
     topology.shellbolt.max.pending: 100
     topology.skip.missing.kryo.registrations: false
     topology.max.task.parallelism: null
    -topology.max.spout.pending: null
    +topology.max.spout.pending: null  # TODO: We dont need this any more
     topology.state.synchronization.timeout.secs: 60
    -topology.stats.sample.rate: 0.05
    +topology.stats.sample.rate: 0.001
    --- End diff --
    
    Ok I personally feel that sampling can be reduced a bit, but if you have a 
preference towards retaining it .... i am ok with that.  JCQueue is at the core 
messaging system .. not separate. the numbers demonstrate the improvement.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to