Github user RPCMoritz commented on a diff in the pull request:
https://github.com/apache/storm/pull/2248#discussion_r130360205
--- Diff:
external/storm-jdbc/src/test/java/org/apache/storm/jdbc/common/JdbcClientTest.java
---
@@ -92,3 +115,27 @@ public void cleanup() {
client.executeSql("drop table " + tableName);
}
}
+
+class MockConnectionProvider implements ConnectionProvider {
+
+ private Map<String, Object> configMap;
+
+ public MockConnectionProvider(Map<String, Object> mockCPConfigMap) {
--- End diff --
The class name could be chosen to be more descriptive --
ThrowingConnectionProvider?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
