Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2108#discussion_r132811153
  
    --- Diff: 
external/storm-solr/src/main/java/org/apache/storm/solr/config/CommitCallback.java
 ---
    @@ -0,0 +1,23 @@
    +/*
    + * OnCommit.java
    + * Copyright 2017 Qunhe Tech, all rights reserved.
    + * Qunhe PROPRIETARY/CONFIDENTIAL, any form of usage is subject to 
approval.
    + */
    +
    +package org.apache.storm.solr.config;
    +
    +import org.apache.solr.client.solrj.SolrClient;
    +import org.apache.solr.client.solrj.SolrServerException;
    +
    +import java.io.IOException;
    +import java.io.Serializable;
    +
    +/**
    + * This callback interface is invoked on {@link SolrCommitStrategy} 
triggers or tick. Typically fire
    + * a "commit" request to solr, you can customize commit details by 
implementing this interface.
    + * @author alei
    + */
    +public interface CommitCallback extends Serializable {
    +
    +    void process(SolrClient solrClient, String collection) throws 
SolrServerException, IOException;
    --- End diff --
    
    Nit: Shouldn't this be named "commit"?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to