Github user revans2 commented on the issue:

    https://github.com/apache/storm/pull/2294
  
    ```
    external/storm-hdfs/src/main/java/org/apache/storm/hdfs/bolt/Writer.java
        18: 'package' should be separated from previous statement.
        23: Wrong lexicographical order for 'java.io.IOException' import. 
Should be before 'org.apache.storm.tuple.Tuple'.
    ```
    
    are the two issues associated with the new file you added.  Then there is 
just one more added in, but because it is changes to existing files it is hard 
to tell, so it is simplest to just pick one or two other issues to "fix" too.
    
    ```
    
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/common/AbstractHDFSWriter.java
        18: 'package' should be separated from previous statement.
        25: Wrong lexicographical order for 'java.io.IOException' import. 
Should be before 'org.apache.storm.tuple.Tuple'.
        27: Abbreviation in name 'AbstractHDFSWriter' must contain no more than 
'2' consecutive capital letters.
        27: 'public' modifier out of order with the JLS suggestions.
        31: 'protected' modifier out of order with the JLS suggestions.
        32: 'protected' modifier out of order with the JLS suggestions.
        34: Missing a Javadoc comment.
        40: Missing a Javadoc comment.
        40: 'public' modifier out of order with the JLS suggestions.
        47: 'public' modifier out of order with the JLS suggestions.
        51: 'public' modifier out of order with the JLS suggestions.
        63: 'protected' modifier out of order with the JLS suggestions.
        65: 'protected' modifier out of order with the JLS suggestions.
        67: 'protected' modifier out of order with the JLS suggestions.
    ``` 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to