Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2297#discussion_r136238719
--- Diff:
external/storm-kafka/src/jvm/org/apache/storm/kafka/DynamicBrokersReader.java
---
@@ -110,7 +110,7 @@ private int getNumPartitions(String topic) {
List<String> children =
_curator.getChildren().forPath(topicBrokersPath);
return children.size();
} catch (Exception e) {
- throw new RuntimeException(e);
+ LOG.error(e.getMessage(), e);
--- End diff --
Which value do you think this method returns when exception is caught,
which action caller should take? Without proper action for failing back, it is
better to throw exception and fail-fast.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
