GitHub user jerrypeng reopened a pull request:
https://github.com/apache/storm/pull/2314
[STORM-2731] - Simple checks in Storm Windowing
There is also inconsistent and mixed used of Longs and Ints throughout the
windowing code. Perhaps we should just change all the numeric values to use
longs? Especially since all calculation of time is done in milliseconds. It
would also be nice to make clear in both the code and documentation that all
timestamps and time based calculations is in milliseconds.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jerrypeng/storm STORM-2731
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2314.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2314
----
commit a64199ac5b5eb59205241ff09cd1d74440ba922f
Author: Jerry Peng <jerrypeng@jerrys-macbook-pro.local>
Date: 2017-09-07T22:32:39Z
[STORM-2731] - Simple checks in Storm Windowing
commit fb7c7a0ff4496d60ed5742702945090ba7c5674a
Author: Jerry Peng <jerrypeng@jerrys-macbook-pro.local>
Date: 2017-09-19T20:46:32Z
fixing exception message
commit f657dfcfadb74c967d4ef8bf711e4c27af6ccf45
Author: Jerry Peng <jerrypeng@jerrys-macbook-pro.local>
Date: 2017-09-19T20:55:08Z
fixing lower case
----
---
