Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2338#discussion_r140339271
  
    --- Diff: 
storm-client/src/jvm/org/apache/storm/cluster/StormClusterStateImpl.java ---
    @@ -423,32 +424,35 @@ public void supervisorHeartbeat(String supervisorId, 
SupervisorInfo info) {
         }
     
         /**
    -     * if znode exists and to be not on?, delete; if exists and on?, do 
nothing; if not exists and to be on?, create; if not exists and not on?, do 
nothing;
    +     * if znode exists and timestamp is 0?, delete; if exists and 
timestamp is larger than 0?, do nothing;
    --- End diff --
    
    Nit: What are the question marks after 0 for?


---

Reply via email to