Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2203#discussion_r140972434
  
    --- Diff: 
storm-core/src/jvm/org/apache/storm/metrics2/StormMetricRegistry.java ---
    @@ -0,0 +1,135 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.storm.metrics2;
    +
    +import com.codahale.metrics.Meter;
    +import com.codahale.metrics.MetricRegistry;
    +import org.apache.storm.Config;
    +import org.apache.storm.cluster.DaemonType;
    +import org.apache.storm.metrics2.reporters.StormReporter;
    +import org.apache.storm.task.WorkerTopologyContext;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import java.net.InetAddress;
    +import java.net.UnknownHostException;
    +import java.util.ArrayList;
    +import java.util.List;
    +import java.util.Map;
    +
    +
    +public class StormMetricRegistry {
    +
    +    private static final Logger LOG = 
LoggerFactory.getLogger(StormMetricRegistry.class);
    +
    +    private static final MetricRegistry REGISTRY = new MetricRegistry();
    +
    +    private static final List<StormReporter> REPORTERS = new ArrayList<>();
    +
    +    private static String hostName = null;
    +
    +    public static <T> SimpleGauge<T>  gauge(T initialValue, String name, 
String topologyId, String componentId, Integer port){
    +        SimpleGauge<T> gauge = new SimpleGauge<>(initialValue);
    +        String metricName = metricName(name, topologyId, componentId, 
port);
    +            if(REGISTRY.getGauges().containsKey(metricName)){
    --- End diff --
    
    If REGISTRY is OK with registering same metrics name multiple time (that 
looks like assumption of `meter()`), we can just make this same as `meter()`.


---

Reply via email to