Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2341#discussion_r142062186
  
    --- Diff: storm-client/src/jvm/org/apache/storm/utils/Utils.java ---
    @@ -550,12 +558,13 @@ public static void handleUncaughtException(Throwable 
t, Set<Class> allowedExcept
                 }
             }
     
    -        if(allowedExceptions.contains(t.getClass())) {
    +        if(alwaysSwallow || allowedExceptions.contains(t.getClass())) {
    --- End diff --
    
    Even `alwaysSwallow` is set to true, we may still want to throw Error on 
`Error`s.


---

Reply via email to