GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2360
STORM-2716: Fix logviewer tests on Windows.
See https://issues.apache.org/jira/browse/STORM-2716.
The tests run on Windows now at least. I haven't tested Logviewer beyond
checking that I can search logs on my local machine from Storm UI, so there may
still be some corners of Logviewer that doesn't work on Windows.
I also removed some constants that were making accessing the file.separator
property easy. I don't think we need them since File.separator exists.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srdo/storm STORM-2716
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2360.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2360
----
commit d8363813e9877b35bb6a8f9006540cf3d0be44e1
Author: Stig Rohde Døssing <[email protected]>
Date: 2017-08-20T16:59:12Z
STORM-2716: Fix logviewer on Windows, and make storm-webapp tests pass on
Windows. Get rid of various constants that were duplicating File.separator and
File.pathSeparator.
----
---
