Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2362#discussion_r143360896
  
    --- Diff: docs/Trident-API-Overview.md ---
    @@ -484,7 +484,7 @@ public class Count implements CombinerAggregator<Long> {
     }
     ```
     
    -The benefits of CombinerAggregators are seen when you use them with the 
aggregate method instead of partitionAggregate. In that case, Trident 
automatically optimizes the computation by doing partial aggregations before 
transferring tuples over the network.
    +CombinerAggregators offer high efficiency when used with the aggregate 
method instead of partitionAggregate (see below).
    --- End diff --
    
    I'm a little unsure which part of the document below this is referring to. 
Can you insert a link instead, e.g. using 
https://gist.github.com/asabaylus/3071099?


---

Reply via email to