GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2367
STORM-2607: Storm-kafka-client never commits the last message on a
partition.
This finishes up https://github.com/apache/storm/pull/2181, which has been
blocked on a rebase for a while. It was suggested on the mailing list that we
finish this up quickly since the fix should ideally go in 1.1.2.
I've squashed the commits as much as possible without mixing up which
changes were made by @tiodollar and which were made by me. Let me know if
squashing is not okay in this case, and I'll rebase on the commits in the
original PR.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srdo/storm STORM-2607-fixup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2367.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2367
----
commit 4dca66c24b4ec40f0ab4badac9042fc3f2d9e01e
Author: Rodolfo Ribeiro <[email protected]>
Date: 2017-06-29T15:06:20Z
[STORM-2607] Offset consumer + 1
commit 51e5f707623e33b877a21c4fe05ad7564aaaf702
Author: Stig Rohde Døssing <[email protected]>
Date: 2017-07-01T15:29:56Z
STORM-2607: Switch OffsetManager to track earliest uncommitted offset
instead of last committed offset for compatibility with commitSync consumer API
commit 99569b2b2318f0559a9705be53ed3e5646b468ad
Author: Rodolfo Ribeiro <[email protected]>
Date: 2017-07-04T22:13:05Z
[STORM-2607] Fixed PR
commit fd0dc1fbd36508069e8f6a906a65120e8a6f60b4
Author: Stig Rohde Døssing <[email protected]>
Date: 2017-10-10T17:11:35Z
Merge branch 'asfgit-master' into STORM-2607-fixup
commit fd50c487f8a07b9705b8172a401374c9784436b2
Author: Stig Rohde Døssing <[email protected]>
Date: 2017-10-10T19:20:06Z
STORM-2607: Fix merge conflicts, fix pending review comment, rename
variables in OffsetManager to be consistent with the KafkaConsumer API
definition of 'committed offset', fix tests, replace uses of deprecated Mockito
methods
----
---
