Github user hmcl commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2367#discussion_r144078200
  
    --- Diff: 
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/OffsetManager.java
 ---
    @@ -53,8 +54,8 @@
         public OffsetManager(TopicPartition tp, long initialFetchOffset) {
             this.tp = tp;
             this.initialFetchOffset = initialFetchOffset;
    -        this.committedOffset = initialFetchOffset - 1;
    -        LOG.debug("Instantiated {}", this);
    +        this.committedOffset = initialFetchOffset;
    +        LOG.debug("Instantiated {}", this.toString());
    --- End diff --
    
    Thanks for the explanation. I just noticed that `this` is called within its 
own constructor, and therefore makes sense. However, IntelliJ does not give me 
this warning.


---

Reply via email to