Github user hmcl commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2380#discussion_r147013620
  
    --- Diff: 
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
 ---
    @@ -125,8 +125,8 @@ public void open(Map<String, Object> conf, 
TopologyContext context, SpoutOutputC
     
             tupleListener = kafkaSpoutConfig.getTupleListener();
     
    -        if (isAtLeastOnce()) {
    -            // Only used if the spout commits offsets for acked tuples
    +        if (isAtLeastOnceProcessing()) {
    +            // Only used if the spout should commit to Kafka an offset 
only after its tuple has been acked.
    --- End diff --
    
    Done.


---

Reply via email to