Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2390#discussion_r147744169
--- Diff:
storm-client/src/jvm/org/apache/storm/blobstore/BlobStoreAclHandler.java ---
@@ -45,6 +47,7 @@
public class BlobStoreAclHandler {
public static final Logger LOG =
LoggerFactory.getLogger(BlobStoreAclHandler.class);
private final IPrincipalToLocal _ptol;
+ private final IGroupMappingServiceProvider _groupMappingProvider;
--- End diff --
We should move away from using '_' as a prefix to member variables. Please
at least fix the new ones to not use it, and if you want to fix all of them
that would be great too.
---
