Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2399#discussion_r148330545
--- Diff: storm-client/src/jvm/org/apache/storm/messaging/netty/Server.java
---
@@ -249,6 +250,15 @@ public Object getState() {
}
}
ret.put("enqueued", enqueued);
+
+ // Report messageSizes metric
+ if (_cb instanceof IMetric) {
+ Object metrics = ((IMetric) _cb).getValueAndReset();
+ if(metrics instanceof Map && !((Map) metrics).isEmpty()) {
--- End diff --
Also fitting with what we had previously. It would be nice to allow an
empty map, but not do anything on null. This would match what we do in other
places working with IMetrics.
---
