Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2385#discussion_r149163756
  
    --- Diff: 
storm-server/src/main/java/org/apache/storm/scheduler/resource/ResourceUtils.java
 ---
    @@ -129,41 +137,65 @@ public static String 
getJsonWithUpdatedResources(String jsonConf, Map<String, Do
             }
         }
     
    -    public static void checkIntialization(Map<String, Double> 
topologyResources, String com,
    -                                          Map<String, Object> 
topologyConf) {
    -        checkInitMem(topologyResources, com, topologyConf);
    -        checkInitCpu(topologyResources, com, topologyConf);
    -    }
    +    public static void checkInitialization(Map<String, Double> 
topologyResources, String componentId, Map topologyConf) {
    --- End diff --
    
    Why are we losing the type hints on topologyConf?


---

Reply via email to