Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2385#discussion_r149143172
--- Diff: storm-client/src/jvm/org/apache/storm/Config.java ---
@@ -241,6 +241,12 @@
public static final String TOPOLOGY_TASKS = "topology.tasks";
/**
+ * A map of resources used by each component e.g {"cpu" : 200.0.
"onheap.memory.mb": 256.0, "gpu" : 0.5 }
--- End diff --
Do we actually want users setting `cpu` as the name of one of the
resources? Because in the code we are looking for `cpu.pcore.percent` or
`topology.component.cpu.pcore.percent` and I really think this is going to
confuse our users. Especially if we are also telling them to use this for the
`SUPERVISOR_RESOURCES_MAP`.
Can we please make sure that the comments here match with what we would
expect the user to actually set, and ideally have them match any naming
convention that we would want them to use?
---
