Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2403#discussion_r149482455
--- Diff: storm-client/src/jvm/org/apache/storm/utils/ShellUtils.java ---
@@ -432,47 +437,47 @@ private void setTimedOut() {
}
- /**
- * Static method to execute a shell command.
- * Covers most of the simple cases without requiring the user to
implement
- * the <code>Shell</code> interface.
- * @param cmd shell command to execute.
- * @return the output of the executed command.
- */
- public static String execCommand(String ... cmd) throws IOException {
- return execCommand(null, cmd, 0L);
- }
-
- /**
- * Static method to execute a shell command.
- * Covers most of the simple cases without requiring the user to
implement
- * the <code>Shell</code> interface.
- * @param env the map of environment key=value
- * @param cmd shell command to execute.
- * @param timeout time in milliseconds after which script should be
marked timeout
- * @return the output of the executed command.o
- */
-
- public static String execCommand(Map<String, String> env, String[] cmd,
- long timeout) throws IOException {
- ShellCommandExecutor exec = new ShellCommandExecutor(cmd, null,
env,
- timeout);
- exec.execute();
- return exec.getOutput();
- }
-
- /**
- * Static method to execute a shell command.
- * Covers most of the simple cases without requiring the user to
implement
- * the <code>Shell</code> interface.
- * @param env the map of environment key=value
- * @param cmd shell command to execute.
- * @return the output of the executed command.
- */
- public static String execCommand(Map<String,String> env, String ...
cmd)
- throws IOException {
- return execCommand(env, cmd, 0L);
- }
+// /**
+// * Static method to execute a shell command.
+// * Covers most of the simple cases without requiring the user to
implement
+// * the <code>Shell</code> interface.
+// * @param cmd shell command to execute.
+// * @return the output of the executed command.
+// */
+// public static String execCommand(String ... cmd) throws IOException {
+// return execCommand(null, cmd, 0L);
+// }
+//
+// /**
+// * Static method to execute a shell command.
+// * Covers most of the simple cases without requiring the user to
implement
+// * the <code>Shell</code> interface.
+// * @param env the map of environment key=value
+// * @param cmd shell command to execute.
+// * @param timeout time in milliseconds after which script should be
marked timeout
+// * @return the output of the executed command.o
+// */
+//
+// public static String execCommand(Map<String, String> env, String[]
cmd,
+// long timeout) throws IOException {
+// ShellCommandExecutor exec = new ShellCommandExecutor(cmd, null,
env,
+// timeout);
+// exec.execute();
+// return exec.getOutput();
+// }
+//
+// /**
+// * Static method to execute a shell command.
+// * Covers most of the simple cases without requiring the user to
implement
+// * the <code>Shell</code> interface.
+// * @param env the map of environment key=value
+// * @param cmd shell command to execute.
+// * @return the output of the executed command.
+// */
+// public static String execCommand(Map<String,String> env, String ...
cmd)
+// throws IOException {
+// return execCommand(env, cmd, 0L);
+// }
--- End diff --
Oops, yes.
---
