Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2409#discussion_r150422396
  
    --- Diff: 
flux/flux-core/src/test/resources/configs/config-methods-test.yaml ---
    @@ -70,8 +70,17 @@ bolts:
                 - "foo"
                 - "bar"
                 - "baz"
    +  - id: "bolt-2"
    +    className: "org.apache.storm.flux.test.TestBolt"
    +    factory: "newInstance"
    +    parallelism: 1
     
    -
    +  - id: "bolt-3"
    +    className: "org.apache.storm.flux.test.TestBolt"
    +    factory: "newInstance"
    +#    factoryArgs:
    --- End diff --
    
    What if we don't comment this two lines? If it just works, I think this two 
lines should not be commented out. If it doesn't work, we may need to make it 
work, cause it is not actual tested.


---

Reply via email to