Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2419#discussion_r150948564
--- Diff:
storm-client/src/jvm/org/apache/storm/coordination/BatchSubtopologyBuilder.java
---
@@ -446,31 +446,26 @@ public String getComponent() {
}
private void addDeclaration(InputDeclaration declaration) {
- _component.declarations.add(declaration);
+ component.declarations.add(declaration);
}
@Override
public BoltDeclarer addConfigurations(Map<String, Object> conf) {
- _component.componentConfs.add(conf);
+ if (conf != null && !conf.isEmpty()) {
--- End diff --
Nit: I think putAll is a no-op when the conf is empty, so you probably
don't need to check.
---
