Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2438#discussion_r154863225
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -242,9 +242,7 @@ public void nextTuple() {
}
}
- if (waitingToEmit()) {
- emit();
- }
+ emitIfWaitingNotEmitted();
--- End diff --
If you're removing the waitingToEmit check, I think you should check for
null in emitIfWaitingNotEmitted.---
