[GitHub] storm pull request #2453: STORM-2851: Fix ConcurrentModificationException in...

[srdo]

Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2453#discussion_r156508668
  
    --- Diff: 
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
 ---
    @@ -230,14 +230,14 @@ public void nextTuple() {
                         kafkaSpoutConfig.getSubscription().refreshAssignment();
                     }
     
    -                if (commit()) {
    +                if (isCommitAllowed()) {
    --- End diff --
    
    How about shouldCommit()?


---