Github user kishorvpatil commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2456#discussion_r157072777
  
    --- Diff: 
storm-server/src/test/java/org/apache/storm/scheduler/resource/TestResourceAwareScheduler.java
 ---
    @@ -640,6 +641,150 @@ public void testHeterogeneousCluster() {
             //end of Test3
         }
     
    +    @Test
    +    public void testHeterogeneousClusterwithGras() {
    --- End diff --
    
    Please refactor to avoid duplicate code.


---

From common-issues-return-145801-archive=mail-archive....@hadoop.apache.org Thu 
Dec 14 13:56:13 2017
Return-path: 
<common-issues-return-145801-archive=mail-archive....@hadoop.apache.org>
Envelope-to: [email protected]
Delivery-date: Thu, 14 Dec 2017 13:56:13 -0800
Received: from c7-b.mxthunder.net ([208.53.48.218])
        by mail-archive.com with esmtp (Exim 4.76)
        (envelope-from 
<common-issues-return-145801-archive=mail-archive....@hadoop.apache.org>)
        id 1ePbUD-0001qZ-7R
        for [email protected]; Thu, 14 Dec 2017 13:56:13 -0800
Received: by bolt10b.mxthunder.net (Postfix, from userid 12345)
        id 3yyS7D4FLBz3571S; Thu, 14 Dec 2017 13:56:06 -0800 (PST)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
        by bolt10b.mxthunder.net (Postfix) with SMTP id 3yyS783WJpz1w0Fp
        for <[email protected]>; Thu, 14 Dec 2017 13:56:04 -0800 (PST)
Received: (qmail 4709 invoked by uid 500); 14 Dec 2017 21:56:04 -0000
Mailing-List: contact [email protected]; run by ezmlm
Precedence: bulk
List-Help: <mailto:[email protected]>
List-Unsubscribe: <mailto:[email protected]>
List-Post: <mailto:[email protected]>
List-Id: <common-issues.hadoop.apache.org>
Delivered-To: mailing list [email protected]
Received: (qmail 4697 invoked by uid 99); 14 Dec 2017 21:56:04 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO 
spamd3-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Dec 2017 21:56:04 +0000
Received: from localhost (localhost [127.0.0.1])
        by spamd3-us-west.apache.org (ASF Mail Server at 
spamd3-us-west.apache.org) with ESMTP id ED1E4180718
        for <[email protected]>; Thu, 14 Dec 2017 21:56:02 +0000 
(UTC)
X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: -99.202
X-Spam-Level:
X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31
        tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001,
        SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled
Received: from mx1-lw-eu.apache.org ([10.40.0.8])
        by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, 
port 10024)
        with ESMTP id 3mZNeus4d64g for <[email protected]>;
        Thu, 14 Dec 2017 21:56:02 +0000 (UTC)
Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org 
[209.188.14.139])
        by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with 
ESMTP id 6B8965F250
        for <[email protected]>; Thu, 14 Dec 2017 21:56:01 +0000 
(UTC)
Received: from jira-lw-us.apache.org (unknown [207.244.88.139])
        by mailrelay1-us-west.apache.org (ASF Mail Server at 
mailrelay1-us-west.apache.org) with ESMTP id AE31AE0026
        for <[email protected]>; Thu, 14 Dec 2017 21:56:00 +0000 
(UTC)
Received: from jira-lw-us.apache.org (localhost [127.0.0.1])
        by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) 
with ESMTP id 65DE3212FB
        for <[email protected]>; Thu, 14 Dec 2017 21:56:00 +0000 
(UTC)
Date: Thu, 14 Dec 2017 21:56:00 +0000 (UTC)
From: "Lukas Waldmann (JIRA)" <[email protected]>
To: [email protected]
Message-ID: <[email protected]>
In-Reply-To: <[email protected]>
References: <[email protected]> 
<[email protected]>
Subject: [jira] [Commented] (HADOOP-14444) New implementation of ftp and
 sftp filesystems
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
X-MXTHUNDER-Identifier:  
<[email protected]>
X-MXTHUNDER-IP-Rating:  0, 140.211.11.3, Ugly c=0.921348 p=-0.985073 Source 
White
X-MXTHUNDER-Scan-Result:  100
X-MXTHUNDER-Rules: 
        100-75141-5451-5465-m
        100-75141-7924-7938-m
        100-75141-0-8061-f
X-MXTHUNDER-Group:  Bulk Mail


    [ 
https://issues.apache.org/jira/browse/HADOOP-14444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16291683#comment-16291683
 ] 

Lukas Waldmann commented on HADOOP-14444:
-----------------------------------------

Hmm, never used this functionality. I will have to check it out. Hopefully I 
will have some spare time over EoY period 

> New implementation of ftp and sftp filesystems
> ----------------------------------------------
>
>                 Key: HADOOP-14444
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14444
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: fs
>    Affects Versions: 2.8.0
>            Reporter: Lukas Waldmann
>            Assignee: Lukas Waldmann
>         Attachments: HADOOP-14444.10.patch, HADOOP-14444.11.patch, 
> HADOOP-14444.12.patch, HADOOP-14444.13.patch, HADOOP-14444.2.patch, 
> HADOOP-14444.3.patch, HADOOP-14444.4.patch, HADOOP-14444.5.patch, 
> HADOOP-14444.6.patch, HADOOP-14444.7.patch, HADOOP-14444.8.patch, 
> HADOOP-14444.9.patch, HADOOP-14444.patch
>
>
> Current implementation of FTP and SFTP filesystems have severe limitations 
> and performance issues when dealing with high number of files. Mine patch 
> solve those issues and integrate both filesystems such a way that most of the 
> core functionality is common for both and therefore simplifying the 
> maintainability.
> The core features:
> * Support for HTTP/SOCKS proxies
> * Support for passive FTP
> * Support for explicit FTPS (SSL/TLS)
> * Support of connection pooling - new connection is not created for every 
> single command but reused from the pool.
> For huge number of files it shows order of magnitude performance improvement 
> over not pooled connections.
> * Caching of directory trees. For ftp you always need to list whole directory 
> whenever you ask information about particular file.
> Again for huge number of files it shows order of magnitude performance 
> improvement over not cached connections.
> * Support of keep alive (NOOP) messages to avoid connection drops
> * Support for Unix style or regexp wildcard glob - useful for listing a 
> particular files across whole directory tree
> * Support for reestablishing broken ftp data transfers - can happen 
> surprisingly often



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to