GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2462
STORM-2858: Fix worker-launcher build by erroring out if asprintf faiâ¦
â¦ls to allocate memory. Replace make-maven-plugin with a build shell
script.
This is part of making the build run on the new Travis Ubuntu image.
I got an error when building storm-core with -Pnative because GCC has
marked asprintf as a function where you shouldn't ignore the return value. I've
put in return value handling that exits the worker-launcher process if asprintf
fails to allocate memory. As part of this I replaced make-maven-plugin, because
it's fairly old (last release in 2009, there doesn't seem to be a page for the
plugin anymore) and opaque (had to decompile the jar to figure out what it was
doing). I think a build script + exec-maven-plugin is less magical. The make
process output now also goes in the terminal when building, which it didn't
with make-maven-plugin.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srdo/storm STORM-2858
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2462.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2462
----
commit 25a2f337a629ed55fde772052ea8ce7015b69462
Author: Stig Rohde Døssing <[email protected]>
Date: 2017-12-13T15:47:31Z
STORM-2858: Fix worker-launcher build by erroring out if asprintf fails to
allocate memory. Replace make-maven-plugin with a build shell script.
----
---
