Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2465#discussion_r157374885
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -134,7 +134,12 @@ public KafkaSpoutConfig(Builder<K, V> builder) {
EARLIEST,
LATEST,
UNCOMMITTED_EARLIEST,
- UNCOMMITTED_LATEST
+ UNCOMMITTED_LATEST;
+
+ @Override
+ public String toString() {
+ return "FirstPollOffsetStrategy{" + super.toString() + "}";
--- End diff --
This toString() makes logging cleaner and more consistent. if you do
log.debug("using {}",firstPollOffsetStrategy) it will print "using
FirstPollOffsetStrategy{EARLIEST}", which follows the pattern of every other
toString() method. If we don't override toString() it will simply print "using
EARLIEST".
---
