Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2241#discussion_r158195454
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java
---
@@ -442,32 +406,29 @@ private WorkerBackpressureCallback
mkBackpressureHandler() {
// in which case it's a noop
workerState.mqContext.term();
LOG.info("Shutting down transfer thread");
- workerState.transferQueue.haltWithInterrupt();
+ workerState.haltWorkerTransfer();
+
transferThread.interrupt();
transferThread.join();
LOG.info("Shut down transfer thread");
- backpressureThread.terminate();
- LOG.info("Shut down backpressure thread");
-
workerState.heartbeatTimer.close();
workerState.refreshConnectionsTimer.close();
workerState.refreshCredentialsTimer.close();
workerState.checkForUpdatedBlobsTimer.close();
- workerState.refreshBackpressureTimer.close();
workerState.refreshActiveTimer.close();
workerState.executorHeartbeatTimer.close();
workerState.userTimer.close();
workerState.refreshLoadTimer.close();
workerState.resetLogLevelsTimer.close();
+ workerState.flushTupleTimer.close();
--- End diff --
Do we want to close workerState.backPressureCheckTimer too?
---
