Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r158665370
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutConfigTest.java
---
@@ -49,6 +49,7 @@ public void testBasic() {
expected.put(ConsumerConfig.KEY_DESERIALIZER_CLASS_CONFIG,
StringDeserializer.class);
expected.put(ConsumerConfig.VALUE_DESERIALIZER_CLASS_CONFIG,
StringDeserializer.class);
assertEquals(expected, conf.getKafkaProps());
+
assertEquals(KafkaSpoutConfig.DEFAULT_METRICS_TIME_BUCKET_SIZE_SECONDS,
conf.getMetricsTimeBucketSizeInSecs());
--- End diff --
This may be in plan to add in next commits. You may want to add a test to
see whether the configured property is also taken into account.
---
