Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r158705885
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -667,6 +672,16 @@ private void
setNonNullSerDeKafkaProp(SerializableDeserializer<K> keyDes, Class<
return this;
}
+ /**
+ * The time period that metrics data in bucketed into.
+ * @param metricsTimeBucketSizeInSecs
+ * @return
--- End diff --
Nit: Don't add empty `@return`, just leave it off.
---
