[GitHub] storm pull request #2433: [STORM-2693] Heartbeats and assignments promotion ...

[danny0405]

Github user danny0405 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2433#discussion_r158768477
  
    --- Diff: 
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
    @@ -1733,13 +1825,24 @@ private TopologyResources 
getResourcesForTopology(String topoId, StormBase base)
             return ret;
         }
     
    +    private boolean isReadyForMKAssignments() throws Exception {
    +        if(isLeader()) {
    +            if(isHeartbeatsRecovered()) {
    +                return true;
    +            }
    +            LOG.info("waiting for worker heartbeats recovery, skipping 
assignments");
    --- End diff --
    
    done


---