Github user srdo commented on the issue:

    https://github.com/apache/storm/pull/2480
  
    Regarding the Kafka upgrade in this:
    
    I think we can keep support for 0.10.0.x by adding a check to 
KafkaSpout.open that checks if the two new consumer methods are present via 
reflection, and disables the new metric if they aren't. Ideally we'd be able to 
use this type of approach any time we add a feature that uses a new method on 
the KafkaConsumer.
    
    It would be fine by me if we only do this in 1.x to retain backward 
compatibility, and just leave out the check in master. Maybe we add a jira 
issue to 2.0.0 that says we're requiring at least 0.10.1.0, so it's visible to 
users upgrading to 2.0.0. 
    
    If we really need to support old Kafka versions indefinitely, we can 
hopefully just keep the reflection checks, but I'd rather use Storm major 
versions as an opportunity to clean up the code and require newer Kafka 
versions.
    
    I believe Kafka guarantees interface stability for KafkaConsumer as of 
0.10.0.0. Since users can specify which kafka-clients version they want when 
they define their topologies, we should not need to maintain different versions 
of storm-kafka-client for different Kafka versions.


---

Reply via email to