Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r159119706
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -739,4 +764,9 @@ public boolean shouldPoll() {
return !this.pollablePartitions.isEmpty();
}
}
+
+ @VisibleForTesting
+ KafkaOffsetMetric getKafkaOffsetMetric() {
--- End diff --
If we start adding a lot of these test methods we would be better off but
creating a class in the tests packaged called KafkaSpoutTest that extends
KafkaSpout and use that one in the tests. All of these methods should go in
this class. WE don't want this class to be very bloated.
---
