Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2502#discussion_r159955584
  
    --- Diff: 
storm-client/src/jvm/org/apache/storm/daemon/metrics/SpoutThrottlingMetrics.java
 ---
    @@ -22,24 +22,25 @@
     
     public class SpoutThrottlingMetrics extends BuiltinMetrics {
         private final CountMetric skippedMaxSpoutMs = new CountMetric();
    -    private final CountMetric skippedThrottleMs = new CountMetric();
         private final CountMetric skippedInactiveMs = new CountMetric();
    +    private final CountMetric skippedBackPressureMs = new CountMetric();
     
         public SpoutThrottlingMetrics() {
             metricMap.put("skipped-max-spout-ms", skippedMaxSpoutMs);
    -        metricMap.put("skipped-throttle-ms", skippedThrottleMs);
             metricMap.put("skipped-inactive-ms", skippedInactiveMs);
    +        metricMap.put("skipped-backpressure-ms", skippedBackPressureMs);
    --- End diff --
    
    ./docs/Metrics.md describes these.  It should be updated to remove 
skipped-throttle-ms and replaced with skipped-backpressure-ms (and preferably 
mention that in older versions of storm skipped-throttle-ms would have been 
similar)


---

Reply via email to