GitHub user erikdw opened a pull request:

    https://github.com/apache/storm/pull/2510

    [STORM-2892] fix PATH substitution in flux tests

    The tests fail when the PATH environment variable has a trailing colon, 
despite that being a valid PATH.
    This happens because it is substituted directly into the resultant YAML 
file, which results in invalid
    YAML (since you cannot end a map's value with ":" in the raw text).
    
    So the solution is to wrap the map value with double-quotes.
    
    Also fix 2 typos in comments in this file.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/erikdw/storm STORM-2892

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2510.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2510
    
----
commit b070bd1077398910ee3f818980d1d1705969485c
Author: Erik Weathers <erikdw@...>
Date:   2018-01-10T06:10:42Z

    [STORM-2892] fix PATH substitution in flux tests
    
    The tests fail when the PATH environment variable has a trailing colon, 
despite that being a valid PATH.
    This happens because it is substituted directly into the resultant YAML 
file, which results in invalid
    YAML (since you cannot end a map's value with ":" in the raw text).
    
    So the solution is to wrap the map value with double-quotes.
    
    Also fix 2 typos in comments in this file.

----


---

Reply via email to