Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2203#discussion_r161080512
  
    --- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj ---
    @@ -265,6 +265,7 @@
          :stats (mk-executor-stats <> (sampling-rate storm-conf))
          :interval->task->metric-registry (HashMap.)
          :task->component (:task->component worker)
    +     :task-metrics (TaskMetrics/taskMetricsMap (first task-ids) (last 
task-ids) worker-context component-id)
    --- End diff --
    
    We can create TaskMetrics instance in task-data and even get rid of the map 
lookup. I guess TaskMetrics doesn't have any executor specific metrics.


---

Reply via email to