Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/2203
  
    I'm trying to optimize more since the number doesn't make me happy. 
    
    I've applied pre-populating metrics (like @revans2 suggested) to avoid 
using ConcurrentHashMap.
    
https://github.com/HeartSaVioR/storm/commits/metrics_v2_experimental_no_concurrentmap
    
    This commit 
(https://github.com/HeartSaVioR/storm/commit/16bfb84ebab98991fe4a8bd284dae9fe2bfe437d)
 represents the difference between 7947a07.
    
    and performance test result from same environment (the number may 
fluctuate, as we know):
    
    > 1.2.0-SNAPSHOT (9fbe283) - NOTE: ran earlier, just copied from above 
result
    
    >> 1st
    
    uptime | acked | acked/sec | failed | 99% | 99.9% | min | max | mean | 
stddev | user | sys | gc | mem
    -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | --
    30 | 552,480 | 18,416.00 | 0 | 4,114,612,223 | 4,731,174,911 | 38,928,384 | 
5,448,400,895 | 1,954,055,956.00 | 966,653,713.81 | 156,170 | 5,290 | 0 | 686.05
    60 | 1,578,480 | 52,616.00 | 0 | 1,695,547,391 | 2,191,523,839 | 6,631,424 
| 2,736,783,359 | 144,862,518.23 | 373,282,085.72 | 192,290 | 27,900 | 5,208 | 
824.31
    91 | 1,505,000 | 48,548.39 | 0 | 36,732,927 | 63,275,007 | 6,549,504 | 
92,340,223 | 14,052,122.48 | 5,284,329.78 | 172,290 | 30,260 | 2,240 | 794.81
    121 | 1,504,400 | 50,146.67 | 0 | 33,505,279 | 55,902,207 | 6,701,056 | 
107,020,287 | 13,687,527.65 | 4,682,294.46 | 169,990 | 30,770 | 2,248 | 818.05
    151 | 1,503,640 | 50,121.33 | 0 | 30,801,919 | 42,827,775 | 6,594,560 | 
62,357,503 | 13,450,356.75 | 4,049,872.91 | 171,380 | 30,030 | 2,217 | 891.86
    181 | 1,504,220 | 50,140.67 | 0 | 31,604,735 | 46,366,719 | 6,414,336 | 
72,417,279 | 13,549,466.35 | 4,224,069.48 | 173,460 | 30,120 | 2,214 | 817.73
    211 | 1,503,580 | 50,119.33 | 0 | 33,816,575 | 46,858,239 | 6,545,408 | 
68,681,727 | 13,536,288.26 | 4,442,740.15 | 169,950 | 30,330 | 2,346 | 759.54
    241 | 1,503,360 | 50,112.00 | 0 | 33,947,647 | 46,792,703 | 6,488,064 | 
68,812,799 | 13,633,138.42 | 4,510,106.94 | 171,560 | 30,490 | 2,456 | 791.93
    271 | 1,052,500 | 35,083.33 | 0 | 28,016,639 | 39,452,671 | 6,586,368 | 
58,949,631 | 13,142,065.09 | 3,481,304.94 | 170,870 | 29,260 | 2,113 | 795.18
    301 | 1,504,320 | 50,144.00 | 0 | 35,454,975 | 60,129,279 | 6,696,960 | 
82,575,359 | 13,781,332.77 | 4,965,559.58 | 171,430 | 30,730 | 2,372 | 826.15
    
    >> 2nd
    
    uptime | acked | acked/sec | failed | 99% | 99.9% | min | max | mean | 
stddev | user | sys | gc | mem
    -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | --
    31 | 547,120 | 17,649.03 | 0 | 4,546,625,535 | 5,049,942,015 | 139,984,896 
| 5,536,481,279 | 2,700,418,416.88 | 836,528,892.27 | 157,850 | 4,930 | 0 | 
845.24
    61 | 1,584,360 | 52,812.00 | 0 | 3,078,619,135 | 3,839,885,311 | 6,590,464 
| 4,284,481,535 | 248,409,981.64 | 629,496,874.97 | 195,980 | 27,490 | 5,697 | 
874.53
    91 | 1,504,680 | 50,156.00 | 0 | 35,258,367 | 53,706,751 | 5,910,528 | 
91,488,255 | 13,589,168.15 | 4,802,833.49 | 174,400 | 29,550 | 2,183 | 871.71
    121 | 1,503,900 | 50,130.00 | 0 | 32,538,623 | 52,789,247 | 6,533,120 | 
100,466,687 | 13,482,307.07 | 4,543,434.30 | 186,560 | 32,360 | 2,524 | 802.76
    151 | 1,503,860 | 50,128.67 | 0 | 32,735,231 | 52,854,783 | 5,849,088 | 
97,976,319 | 13,396,304.62 | 4,506,368.26 | 188,430 | 31,780 | 2,514 | 785.88
    181 | 1,503,340 | 50,111.33 | 0 | 29,802,495 | 41,156,607 | 6,737,920 | 
63,209,471 | 13,106,089.43 | 3,755,495.86 | 172,070 | 29,540 | 2,151 | 959.27
    211 | 1,503,740 | 50,124.67 | 0 | 33,423,359 | 52,625,407 | 6,549,504 | 
85,000,191 | 13,426,039.55 | 4,508,334.58 | 187,360 | 32,380 | 2,525 | 869.87
    241 | 1,578,440 | 52,614.67 | 0 | 32,129,023 | 50,102,271 | 6,549,504 | 
88,276,991 | 13,265,778.42 | 4,265,565.26 | 172,610 | 29,340 | 2,308 | 928.26
    271 | 1,503,060 | 50,102.00 | 0 | 30,457,855 | 45,678,591 | 6,565,888 | 
73,662,463 | 13,237,281.21 | 4,002,588.03 | 173,180 | 30,550 | 2,291 | 870.36
    301 | 1,541,260 | 51,375.33 | 0 | 30,932,991 | 44,498,943 | 6,569,984 | 
67,010,559 | 13,223,793.77 | 4,002,853.30 | 172,220 | 29,830 | 2,302 | 1,032.96
    
    >> 3rd
    
    uptime | acked | acked/sec | failed | 99% | 99.9% | min | max | mean | 
stddev | user | sys | gc | mem
    -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | --
    30 | 548,680 | 18,289.33 | 0 | 4,353,687,551 | 5,096,079,359 | 6,729,728 | 
5,742,002,175 | 1,426,311,406.48 | 1,230,114,275.09 | 232,920 | 14,020 | 4,188 
| 999.57
    60 | 1,586,360 | 52,878.67 | 0 | 49,643,519 | 85,590,015 | 6,541,312 | 
142,082,047 | 15,200,355.35 | 7,698,991.41 | 180,110 | 33,300 | 2,347 | 1,068.73
    90 | 1,504,920 | 50,164.00 | 0 | 35,487,743 | 54,067,199 | 6,561,792 | 
95,354,879 | 13,937,343.35 | 4,915,338.14 | 177,210 | 33,140 | 2,256 | 929.59
    120 | 1,504,980 | 50,166.00 | 0 | 34,340,863 | 54,558,719 | 6,602,752 | 
88,473,599 | 13,562,930.72 | 4,524,856.58 | 173,670 | 33,470 | 1,986 | 864.86
    150 | 1,503,660 | 50,122.00 | 0 | 34,504,703 | 55,017,471 | 6,565,888 | 
92,078,079 | 13,860,952.27 | 4,777,727.70 | 174,370 | 34,090 | 2,161 | 774.05
    180 | 1,503,600 | 50,120.00 | 0 | 33,751,039 | 60,424,191 | 6,451,200 | 
95,289,343 | 13,589,277.01 | 4,608,156.04 | 173,400 | 33,630 | 2,007 | 827.87
    210 | 1,503,720 | 50,124.00 | 0 | 34,897,919 | 53,837,823 | 6,516,736 | 
98,762,751 | 13,685,180.92 | 4,693,178.95 | 175,140 | 33,480 | 2,152 | 968.80
    240 | 1,503,700 | 50,123.33 | 0 | 29,491,199 | 41,615,359 | 6,664,192 | 
56,950,783 | 13,332,893.81 | 3,650,722.97 | 172,450 | 34,100 | 2,072 | 1,033.92
    270 | 1,503,740 | 50,124.67 | 0 | 32,489,471 | 52,166,655 | 6,582,272 | 
89,849,855 | 13,618,637.84 | 4,410,814.52 | 174,970 | 33,340 | 2,220 | 951.23
    300 | 1,503,680 | 50,122.67 | 0 | 33,816,575 | 56,819,711 | 6,529,024 | 
93,585,407 | 13,725,888.45 | 4,696,609.51 | 175,230 | 34,010 | 2,195 | 856.02
    
    > metrics_v2_experimental_no_concurrentmap (16bfb84)
    
    >> 1st
    
    uptime | acked | acked/sec | failed | 99% | 99.9% | min | max | mean | 
stddev | user | sys | gc | mem
    -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | --
    30 | 521,520 | 17,384.00 | 0 | 4,399,824,895 | 5,045,747,711 | 6,934,528 | 
5,477,761,023 | 1,469,175,272.67 | 1,227,057,711.53 | 234,080 | 14,040 | 4,695 
| 908.15
    60 | 1,606,960 | 53,565.33 | 0 | 69,271,551 | 103,284,735 | 6,688,768 | 
162,267,135 | 16,658,963.11 | 10,820,914.29 | 182,970 | 34,860 | 2,771 | 979.37
    90 | 1,504,340 | 50,144.67 | 0 | 35,684,351 | 56,655,871 | 6,483,968 | 
84,934,655 | 14,319,765.18 | 5,196,090.29 | 177,360 | 35,080 | 2,555 | 910.11
    120 | 1,504,440 | 50,148.00 | 0 | 42,598,399 | 64,028,671 | 6,545,408 | 
98,172,927 | 14,845,882.32 | 6,251,116.95 | 176,930 | 36,150 | 2,558 | 980.91
    150 | 1,503,540 | 50,118.00 | 0 | 42,729,471 | 68,157,439 | 6,672,384 | 
104,595,455 | 14,860,992.18 | 6,509,952.92 | 178,420 | 34,780 | 2,796 | 1,061.21
    180 | 1,504,140 | 50,138.00 | 0 | 39,190,527 | 60,882,943 | 6,672,384 | 
94,633,983 | 14,737,694.74 | 5,853,681.71 | 178,500 | 35,200 | 2,693 | 955.32
    211 | 1,578,400 | 50,916.13 | 0 | 37,847,039 | 54,624,255 | 6,643,712 | 
84,017,151 | 14,453,282.24 | 5,461,094.50 | 176,050 | 36,140 | 2,697 | 970.97
    241 | 1,503,560 | 50,118.67 | 0 | 36,438,015 | 61,571,071 | 6,840,320 | 
96,468,991 | 14,225,087.83 | 5,308,578.55 | 176,480 | 35,390 | 2,575 | 1,019.94
    271 | 1,540,760 | 51,358.67 | 0 | 39,026,687 | 61,505,535 | 6,656,000 | 
92,733,439 | 14,594,623.83 | 5,757,367.59 | 177,650 | 35,090 | 2,679 | 926.07
    301 | 1,541,500 | 51,383.33 | 0 | 38,174,719 | 59,211,775 | 6,684,672 | 
95,354,879 | 14,409,348.75 | 5,516,131.31 | 178,830 | 35,540 | 2,695 | 1,045.45
    
    >> 2nd
    
    uptime | acked | acked/sec | failed | 99% | 99.9% | min | max | mean | 
stddev | user | sys | gc | mem
    -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | --
    30 | 491,720 | 16,390.67 | 0 | 4,630,511,615 | 5,200,936,959 | 697,827,328 
| 6,450,839,551 | 2,954,778,417.40 | 727,057,988.48 | 162,780 | 4,840 | 0 | 
979.28
    60 | 1,644,340 | 54,811.33 | 0 | 4,049,600,511 | 4,999,610,367 | 6,533,120 
| 6,010,437,631 | 427,496,180.15 | 939,785,497.10 | 199,550 | 26,590 | 6,217 | 
862.49
    91 | 1,504,540 | 48,533.55 | 0 | 36,601,855 | 66,191,359 | 6,664,192 | 
105,775,103 | 13,706,877.48 | 5,370,404.76 | 175,600 | 30,200 | 2,227 | 895.71
    121 | 1,504,480 | 50,149.33 | 0 | 31,997,951 | 50,069,503 | 6,660,096 | 
80,412,671 | 13,450,225.43 | 4,373,525.30 | 175,600 | 30,240 | 2,284 | 875.98
    151 | 1,503,660 | 50,122.00 | 0 | 34,111,487 | 52,297,727 | 6,586,368 | 
98,566,143 | 13,480,758.21 | 4,678,095.67 | 175,200 | 30,180 | 2,343 | 934.79
    181 | 1,053,000 | 35,100.00 | 0 | 32,931,839 | 52,330,495 | 6,610,944 | 
94,765,055 | 13,465,337.48 | 4,505,964.49 | 175,340 | 29,930 | 2,278 | 904.00
    211 | 1,503,740 | 50,124.67 | 0 | 30,736,383 | 51,445,759 | 6,664,192 | 
100,663,295 | 13,283,596.54 | 4,161,045.70 | 173,040 | 30,320 | 2,185 | 895.06
    241 | 1,503,240 | 50,108.00 | 0 | 29,966,335 | 45,252,607 | 6,459,392 | 
83,755,007 | 13,228,833.30 | 3,991,498.48 | 174,480 | 29,770 | 2,240 | 978.94
    271 | 1,503,620 | 50,120.67 | 0 | 34,832,383 | 66,125,823 | 5,836,800 | 
113,377,279 | 13,441,046.90 | 4,988,144.19 | 174,780 | 30,100 | 2,170 | 1,071.04
    301 | 1,503,080 | 50,102.67 | 0 | 28,803,071 | 42,074,111 | 6,541,312 | 
83,230,719 | 13,192,828.23 | 3,707,982.62 | 175,040 | 30,120 | 2,113 | 857.25
    
    >> 3rd
    
    uptime | acked | acked/sec | failed | 99% | 99.9% | min | max | mean | 
stddev | user | sys | gc | mem
    -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | -- | --
    30 | 483,300 | 16,110.00 | 0 | 4,647,288,831 | 4,987,027,455 | 363,593,728 
| 5,167,382,527 | 2,656,646,673.63 | 894,929,695.23 | 166,910 | 5,720 | 0 | 
755.34
    60 | 1,617,040 | 53,901.33 | 0 | 2,904,555,519 | 3,615,490,047 | 6,737,920 
| 5,108,662,271 | 325,444,499.35 | 723,455,445.52 | 200,000 | 31,040 | 6,404 | 
752.83
    90 | 1,504,740 | 50,158.00 | 0 | 37,257,215 | 53,280,767 | 6,643,712 | 
88,801,279 | 14,171,055.76 | 5,259,143.02 | 176,470 | 33,700 | 2,347 | 746.73
    120 | 1,541,400 | 51,380.00 | 0 | 36,503,551 | 64,225,279 | 6,365,184 | 
99,811,327 | 14,060,286.02 | 5,257,312.87 | 177,300 | 34,140 | 2,367 | 865.11
    150 | 1,504,100 | 50,136.67 | 0 | 31,965,183 | 47,087,615 | 6,520,832 | 
72,876,031 | 13,676,703.90 | 4,217,773.93 | 176,160 | 33,900 | 2,161 | 813.44
    180 | 1,503,380 | 50,112.67 | 0 | 35,258,367 | 52,428,799 | 6,574,080 | 
78,708,735 | 13,875,370.00 | 4,743,837.05 | 175,330 | 34,270 | 2,205 | 852.89
    210 | 1,503,340 | 50,111.33 | 0 | 36,110,335 | 52,723,711 | 6,533,120 | 
72,744,959 | 14,058,808.13 | 4,942,078.12 | 175,140 | 34,610 | 2,361 | 763.39
    240 | 1,503,380 | 50,112.67 | 0 | 31,637,503 | 46,792,703 | 6,541,312 | 
70,320,127 | 13,725,854.01 | 4,195,361.27 | 174,920 | 34,830 | 2,200 | 809.84
    270 | 1,503,760 | 50,125.33 | 0 | 35,782,655 | 59,047,935 | 5,570,560 | 
86,966,271 | 14,092,484.98 | 5,063,063.00 | 175,940 | 34,340 | 2,460 | 809.07
    300 | 1,503,080 | 50,102.67 | 0 | 35,717,119 | 74,711,039 | 6,598,656 | 
127,664,127 | 14,072,543.88 | 5,513,555.56 | 174,800 | 34,460 | 2,358 | 818.58



---

Reply via email to