Github user agresch commented on a diff in the pull request:
https://github.com/apache/storm/pull/2531#discussion_r164854143
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2254,14 +2262,13 @@ private void renewCredentials() throws Exception {
}
IStormClusterState state = stormClusterState;
Collection<ICredentialsRenewer> renewers = credRenewers;
- Object lock = credUpdateLock;
Map<String, StormBase> assignedBases = state.topologyBases();
if (assignedBases != null) {
for (Entry<String, StormBase> entry: assignedBases.entrySet())
{
String id = entry.getKey();
String ownerPrincipal = entry.getValue().get_principal();
Map<String, Object> topoConf =
Collections.unmodifiableMap(Utils.merge(conf, tryReadTopoConf(id, topoCache)));
- synchronized(lock) {
+ synchronized(credUpdateLock) {
--- End diff --
was this just wrong? Does it need update in other releases?
---
