Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2538#discussion_r165853784
  
    --- Diff: 
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
 ---
    @@ -142,7 +139,7 @@ public void open(Map<String, Object> conf, 
TopologyContext context, SpoutOutputC
             offsetManagers = new HashMap<>();
             emitted = new HashSet<>();
             waitingToEmit = new HashMap<>();
    -        setCommitMetadata(context);
    +        commitMetadataManager = new CommitMetadataManager(context, 
kafkaSpoutConfig.getProcessingGuarantee());
    --- End diff --
    
    I think we should wait. Let's do it if someone needs it, but introducing 
more extension points than we need is likely to cause us more headaches down 
the road, because once the extension point is public it's harder for us to 
change if we need to because we have to consider that other people may be 
implementing the interface.


---

Reply via email to